Add interceptor to aggregate CCFB reports #374
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 79.62% 79.71% +0.09%
==========================================
Files 84 88 +4
Lines 4181 4486 +305
==========================================
+ Hits 3329 3576 +247
- Misses 680 729 +49
- Partials 172 181 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
feat/rtpfb-receiver-2
branch
6 times, most recently
from
0912350 to
ceaeb98
Compare
pkg/rtpfb/ccfb_receiver.go
Outdated
| } | ||
| } | ||
|
|
||
| return referenceTime.Sub(latestArrival), result |
There was a problem hiding this comment.
What will happen if latestArrival is never set? shouldn't we return 0, nil?
There was a problem hiding this comment.
Good point, I think we should initialize latestArrival as latestArrival = referenceTime. That way it will be 0 if it is there were no packets received after the reference time.
There was a problem hiding this comment.
Sorry, this doesn't work because we are actually looking for the latest arrival before the referenceTime. So you're right, we have to add a check and return 0.
mengelbart
force-pushed
the
feat/rtpfb-receiver-2
branch
from
5d878ee to
e2d4aff
Compare
mengelbart
force-pushed
the
feat/rtpfb-receiver-2
branch
from
e2d4aff to
82ff788
Compare
Alternative but cleaner implementation for congestion control feedback receiver (#300). The main difference between this and #300 is that #300 organizes the feedback per stream, while this version organizes it as a single linear stream, which is easier to process. If one still needs to know which stream a packet was sent on, that information is still included in the reports for each packet.